GitHub PR

Pull Request(PR) ๋ณด๋‚ด๋Š” ๋ฐฉ๋ฒ•

  1. ๋ถ€๋ชจ ์ €์žฅ์†Œ๋ฅผ ํฌํฌํ•˜์ž.

  2. ๋‚ด ์ €์žฅ์†Œ์— ํฌํฌ๋œ ํ”„๋กœ์ ํŠธ๋ฅผ git cloneํ•˜์ž.

    git clone git@github.com:teamsmiley/idsvr-helm.git
  3. ์›๊ฒฉ ์ €์žฅ์†Œ Remote ์„ค์ •ํ•˜๊ธฐ

    • PR์„ ๋ณด๋‚ผ ๊ณณ์„ ์ถ”๊ฐ€.

    • ์›๊ฒฉ ์ €์žฅ์†Œ์˜ ์ด๋ฆ„์€ upstream ์œผ๋กœ ์ง€์ •

    • ์›๊ฒฉ ์ €์žฅ์†Œ์˜ git ์ฃผ์†Œ๋Š” fork๋ฅผ ํ•˜๊ธฐ ์ „ ์›๋ž˜์˜ ์ €์žฅ์†Œ๋ฅผ ๋งํ•ฉ๋‹ˆ๋‹ค.

      # git remote add upstream https://github.com/ORIGIN_OWNER/ORIGIN_REPO.git
      git remote add upstream https://github.com/curityio/idsvr-helm.git
  4. PR์šฉ branch ์ƒ์„ฑํ•˜๊ธฐ

    git checkout -b update-svc-selector
  5. ์ฝ”๋“œ ์ˆ˜์ • / ์ปค๋ฐ‹ / ํ‘ธ์‹œ

    selector:
      app.kubernetes.io/name: {{ include "curity.name" . }}
      app.kubernetes.io/instance: {{ .Release.Name }}
      role: {{ include "curity.fullname" . }}-admin
    git add --all && git commit -m "admin-svc-selector-update" && git push origin update-svc-selector

  6. github์—์„œ PR ๋ณด๋‚ด๊ธฐ

    github์›น์‚ฌ์ดํŠธ์— ๊ฐ€๋ณด๋ฉด compare & pull request๋ฒ„ํŠผ์ด ํ™œ์„ฑํ™” ๋˜์žˆ๋‹ค. ์—ฌ๊ธฐ์„œ PR์„ ๋ณด๋‚ด๋ฉด ์›๊ฒฉ ์ €์žฅ์†Œ์— ์ƒˆ๋กœ์šด ๋ฒ„์ „์ด ์ƒ์„ฑ๋œ๋‹ค. ์œ„ ๊ทธ๋ฆผ์— ์žˆ๋Š” ๋กœ๊ทธ์— ๊ฒฝ๋กœ๋กœ ์ง์ ‘ ์ ‘์†ํ•ด๋„ ๋จ.

  7. ๋ถ€๋ชจ ํ”„๋กœ์ ํŠธ์— PR์ด ์žˆ๋Š”์ง€ ํ™•์ธํ•˜๊ธฐ

  8. ๋จธ์ง€๋ ๋•Œ๊ฐ€์ง€ ๊ธฐ๋‹ค๋ฆฐ๋‹ค. ๋จธ์ง€๋˜๋ฉด ๋‚ด ๋ธŒ๋žœ์น˜๋Š” ์ง€์›Œ๋„ ๋œ๋‹ค. ๋กœ์ปฌํ•˜๊ณ  ๋ฆฌ๋ชจํŠธ ๋ชจ๋‘๋‹ค.

approve ์™„๋ฃŒ

๋ช‡์ผ์žˆ๋‹ค merge๋ซ๋‹ค๋Š” ์ด๋ฉ”์ผ์ด ์˜จ๋‹ค.

์™„๋ฃŒ

Last updated

Was this helpful?